[PATCH v2 1/2] staging: rtl8188eu: Deletion of unnecessary checks before three function calls
Julia Lawall
julia.lawall at lip6.fr
Wed Nov 12 21:40:34 UTC 2014
> > This is especially true if you have trained yourself to know that
> > free_netdev() can't accept NULL pointers.
>
> Do you need to adjust your concerns a bit over time when function variants
> provide a corresponding safety check in their implementations?
There would not seem to be any _need_ to do so. An unnecessary null test
is always safe. The only real problem that I can see with an unnecessary
null test in error handling code (intrinsically not critical performance
wise) is if it gives the illusion that a value can be null when it cannot.
julia
More information about the devel
mailing list