[PATCH 02/15] staging: unisys: parser_init & parser_init_byteStream camel case

Dan Carpenter dan.carpenter at oracle.com
Wed Nov 12 16:03:56 UTC 2014


On Wed, Nov 12, 2014 at 09:10:01AM -0500, Jeffrey wrote:
> Fixed all of the camel cases in the two structs parser_init and
> parser_init_byteStream in parser.h
> isLocal => is_local
> tryAgain => tryagain

Use "try_again" instead of "tryagain".

The one thing per patch rule is a bit vague.  Really it's "one complete
thing" per patch and not 1 thing split across five patches.  Now we're
in a state where the .c and .h file don't match so that's bad.

Also if there are are minor closely related things then you are allowed
to do those in the same patch.  This is a very tricky part of the rule.
But changing the .h file is a minor part of changing the .c file and
normally you would barely even comment on it in the changelog because
it's obvious when you need to change the .h file if you change the .c
file.

Also fix parser_init_byteStream at the same time.

Breaking the patches up is supposed to make reviewing easier but this
is making it harder.

Sorry to come down so hard one for this.  Please redo these.

regards,
dan carpenter



More information about the devel mailing list