[PATCH 07/27] Staging: bcm: Shortenend lines in GetNextTargetBufferLocation()

Dan Carpenter dan.carpenter at oracle.com
Mon May 26 08:38:25 UTC 2014


On Fri, May 23, 2014 at 10:23:45PM +0200, Matthias Beyer wrote:
> Signed-off-by: Matthias Beyer <mail at beyermatthias.de>
> ---
>  drivers/staging/bcm/CmHost.c | 14 ++++++++++----
>  1 file changed, 10 insertions(+), 4 deletions(-)
> 
> diff --git a/drivers/staging/bcm/CmHost.c b/drivers/staging/bcm/CmHost.c
> index 3f29dea..9fea9a8 100644
> --- a/drivers/staging/bcm/CmHost.c
> +++ b/drivers/staging/bcm/CmHost.c
> @@ -1531,12 +1531,14 @@ ULONG SetUpTargetDsxBuffers(struct bcm_mini_adapter *Adapter)
>  	return 1;
>  }
>  
> -static ULONG GetNextTargetBufferLocation(struct bcm_mini_adapter *Adapter, B_UINT16 tid)
> +static ULONG GetNextTargetBufferLocation(struct bcm_mini_adapter *Adapter,
> +		B_UINT16 tid)
>  {
>  	ULONG dsx_buf;
>  	ULONG idx, max_try;
>  
> -	if ((Adapter->ulTotalTargetBuffersAvailable == 0) || (Adapter->ulFreeTargetBufferCnt == 0)) {
> +	if ((Adapter->ulTotalTargetBuffersAvailable == 0)
> +			|| (Adapter->ulFreeTargetBufferCnt == 0)) {

Haven't we had this discussion?  The "||" goes on the first line and the
indenting needs to be lined up.

	if ((Adapter->ulTotalTargetBuffersAvailable == 0) ||
	    (Adapter->ulFreeTargetBufferCnt == 0)) {


>  		ClearTargetDSXBuffer(Adapter, tid, false);
>  		return 0;
>  	}

regards,
dan carpenter



More information about the devel mailing list