[PATCH 10/48] staging: rtl8723au: Do not call netdev_open23a() from cfg80211_rtw_change_iface()

Jes.Sorensen at redhat.com Jes.Sorensen at redhat.com
Sun May 25 20:43:10 UTC 2014


From: Jes Sorensen <Jes.Sorensen at redhat.com>

Calling open on the device when changing the interface type is wrong.
Let the stack call open at the right time.

Signed-off-by: Jes Sorensen <Jes.Sorensen at redhat.com>
---
 drivers/staging/rtl8723au/os_dep/ioctl_cfg80211.c | 9 ---------
 1 file changed, 9 deletions(-)

diff --git a/drivers/staging/rtl8723au/os_dep/ioctl_cfg80211.c b/drivers/staging/rtl8723au/os_dep/ioctl_cfg80211.c
index f75a825..2bcdbe1 100644
--- a/drivers/staging/rtl8723au/os_dep/ioctl_cfg80211.c
+++ b/drivers/staging/rtl8723au/os_dep/ioctl_cfg80211.c
@@ -1391,15 +1391,6 @@ static int cfg80211_rtw_change_iface(struct wiphy *wiphy,
 	int ret = 0;
 
 	DBG_8723A("%s(%s): call netdev_open23a\n", __func__, ndev->name);
-	if (netdev_open23a(ndev) != 0) {
-		ret = -EPERM;
-		goto exit;
-	}
-
-	if (_FAIL == rtw_pwr_wakeup(padapter)) {
-		ret = -EPERM;
-		goto exit;
-	}
 
 	old_type = rtw_wdev->iftype;
 	DBG_8723A("%s(%s): old_iftype =%d, new_iftype =%d\n",
-- 
1.9.3



More information about the devel mailing list