[PATCH 3/8 V2] drivers/staging: Remove useless return variables

Greg Kroah-Hartman gregkh at linuxfoundation.org
Sun May 25 18:08:55 UTC 2014


On Sat, May 24, 2014 at 01:06:48PM +0200, Peter Senna Tschudin wrote:
> This patch remove variables that are initialized with a constant,
> are never updated, and are only used as parameter of return.
> Return the constant instead of using a variable.
> 
> Verified by compilation only.
> 
> The coccinelle script that find and fixes this issue is:
> // <smpl>
> @@
> type T;
> constant C;
> identifier ret;
> @@
> - T ret = C;
> ... when != ret
>     when strict
> return
> - ret
> + C
> ;
> // </smpl>
> 
> Signed-off-by: Peter Senna Tschudin <peter.senna at gmail.com>
> 
> ---
> Changes from V1:
>  - Updated semantic patch
>  - Refreshed for next-20140523

Can you refresh again?  It still doesn't apply :(

thanks,

greg k-h


More information about the devel mailing list