r8192e_pci driver broken 3.14+
Sean MacLennan
seanm at seanm.ca
Thu May 22 02:39:43 UTC 2014
On Sat, 19 Apr 2014 16:57:45 -0400
Sean MacLennan <seanm at seanm.ca> wrote:
> A sparse error fixup removed a htons() which is required for the
> driver to function. This patch puts the htons() back and fixes the
> sparse warning correctly by changing the left side cast.
>
> Signed-off-by: Sean MacLennan <seanm at seanm.ca>
> ---
> diff --git a/drivers/staging/rtl8192e/rtllib_tx.c
> b/drivers/staging/rtl8192e/rtllib_tx.c index 11d0a9d..b7dd153 100644
> --- a/drivers/staging/rtl8192e/rtllib_tx.c
> +++ b/drivers/staging/rtl8192e/rtllib_tx.c
> @@ -171,7 +171,7 @@ inline int rtllib_put_snap(u8 *data, u16 h_proto)
> snap->oui[1] = oui[1];
> snap->oui[2] = oui[2];
>
> - *(u16 *)(data + SNAP_SIZE) = h_proto;
> + *(__be16 *)(data + SNAP_SIZE) = htons(h_proto);
>
> return SNAP_SIZE + sizeof(u16);
> }
Any status on this patch?
Cheers,
Sean
More information about the devel
mailing list