[PATCH 72/74] staging: rtl8723au: rtw_mlme_ext.c: Fixup some more unreadable formatting

Dan Carpenter dan.carpenter at oracle.com
Wed May 21 21:40:27 UTC 2014


On Wed, May 21, 2014 at 09:38:36AM +0200, Jes.Sorensen at redhat.com wrote:
> @@ -6243,7 +6241,7 @@ int setkey_hdl23a(struct rtw_adapter *padapter, const u8 *pbuf)
>  		pmlmeinfo->key_index = pparm->keyid;
>  
>  	/* write cam */
> -	ctrl = BIT(15) | ((pparm->algorithm) << 2) | pparm->keyid;
> +	ctrl = BIT(15) | (pparm->algorithm) << 2 | pparm->keyid;
                         ^^^^^^^^^^^^^^^^^^^^^^^
Heh.  It doesn't matter either way, but if I had to choose I would
probably have kept the outer parens.  :P

Anyway, I'm done reviewing this patch set.  Looks good.

regards,
dan carpenter



More information about the devel mailing list