[PATCH] staging: dgap: fix smatch warn: missing break in case

Mark Hounschell markh at compro.net
Wed May 21 20:08:33 UTC 2014


On 05/21/2014 03:59 PM, Dan Carpenter wrote:
> On Wed, May 21, 2014 at 01:03:09PM -0400, Mark Hounschell wrote:
>> This patch fixes an smatch warning about a missing break
>> in a case statement. 
>>
> 
> I would prefer if we leave the code as-is and fix Smatch.  The fix will
> be to read the previous line or two for the word "fall" so just moving
> the comment down a line would silence the warning.
> 

I kinda thought that code was OK. I'll leave it as-is.

Thanks
Mark



More information about the devel mailing list