[PATCH 46/74] staging: rtl8723au: rtl8723a_cmd.c: Use ieee80211.h provided fctl bits

[Jes Sorensen]

Dan Carpenter <dan.carpenter at oracle.com> writes:
> On Wed, May 21, 2014 at 09:38:10AM +0200, Jes.Sorensen at redhat.com wrote:
>>  drivers/staging/rtl8723au/hal/rtl8723a_cmd.c | 23 +++++++++++++----------
>>  1 file changed, 13 insertions(+), 10 deletions(-)
>> 
>> diff --git a/drivers/staging/rtl8723au/hal/rtl8723a_cmd.c b/drivers/staging/rtl8723au/hal/rtl8723a_cmd.c
>> index eb747d6..5f188af 100644
>> --- a/drivers/staging/rtl8723au/hal/rtl8723a_cmd.c
>> +++ b/drivers/staging/rtl8723au/hal/rtl8723a_cmd.c
>> @@ -215,7 +215,7 @@ static void ConstructBeacon(struct rtw_adapter *padapter, u8 *pframe, u32 *pLeng
>>  
>>  	pwlanhdr = (struct ieee80211_hdr *)pframe;
>>  
>> -	pwlanhdr->frame_control = 0;
>> +	pwlanhdr->frame_control = IEEE80211_FTYPE_MGMT | IEEE80211_STYPE_BEACON;
>
> This looks like an endian bug.
>
> It would be very easy to send a v2 version of this patch without
> touching any of the others but it will also not hurt my feelings if you
> fix this in a later patch.  It is up to you and Greg.

I'd say you are indeed correct - I'll post a fix.

Thanks for catching this!

Jes