[PATCH 04/74] staging: rtl8723au: HalEEValueCheck(): content of a u8 is always >= 0

Dan Carpenter dan.carpenter at oracle.com
Wed May 21 08:27:16 UTC 2014


On Wed, May 21, 2014 at 09:37:28AM +0200, Jes.Sorensen at redhat.com wrote:
> From: Jes Sorensen <Jes.Sorensen at redhat.com>
> 
> Signed-off-by: Jes Sorensen <Jes.Sorensen at redhat.com>
> ---
>  drivers/staging/rtl8723au/hal/rtl8723a_hal_init.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/staging/rtl8723au/hal/rtl8723a_hal_init.c b/drivers/staging/rtl8723au/hal/rtl8723a_hal_init.c
> index e2d426a..0afc742 100644
> --- a/drivers/staging/rtl8723au/hal/rtl8723a_hal_init.c
> +++ b/drivers/staging/rtl8723au/hal/rtl8723a_hal_init.c
> @@ -1720,9 +1720,9 @@ static void Hal_EEValueCheck(u8 EEType, void *pInValue, void *pOutValue)
>  		u8 *pIn, *pOut;
>  		pIn = (u8 *) pInValue;
>  		pOut = (u8 *) pOutValue;
> -		if (*pIn >= 0 && *pIn <= 63) {
> +		if (*pIn <= 63)
>  			*pOut = *pIn;
> -		} else {
> +		else {

Don't resend but the curly braces were the correct kernel style in the
original.  If one side gets braces then both do.

regards,
dan carpenter



More information about the devel mailing list