[PATCH v2 05/06] staging: crypto: skein: rename macros

Dan Carpenter dan.carpenter at oracle.com
Mon May 19 09:08:39 UTC 2014


On Mon, May 19, 2014 at 12:09:58PM +0400, Anton Saraev wrote:
> +/* ignore all asserts, for performance */
> +#define skein_assert_ret(x, ret_code)
> +#define skein_assert(x)

Not related to this patch, but defining away asserts like this is a bad
idea.  What if they have side affects like:

	skein_assert(foo++ == bar);

regards,
dan carpenter



More information about the devel mailing list