[PATCH] Staging: dgnc: Fix smatch warning for redundant null check in dgnc_driver.c

Greg KH gregkh at linuxfoundation.org
Thu May 15 20:37:44 UTC 2014


On Wed, May 07, 2014 at 02:41:48PM +0300, Ebru Akagunduz wrote:
> Fix smatch warning "dgnc_cleanup_board() info:
> redundant null check on brd->flipbuf calling kfree()"
> in dgnc_driver.c
> 
> Signed-off-by: Ebru Akagunduz <ebru.akagunduz at gmail.com>
> ---
>  drivers/staging/dgnc/dgnc_driver.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/drivers/staging/dgnc/dgnc_driver.c b/drivers/staging/dgnc/dgnc_driver.c
> index b1a39b2..e579ba3 100644
> --- a/drivers/staging/dgnc/dgnc_driver.c
> +++ b/drivers/staging/dgnc/dgnc_driver.c
> @@ -463,8 +463,7 @@ static void dgnc_cleanup_board(struct dgnc_board *brd)
>  		}
>  	}
>  
> -	if (brd->flipbuf)
> -		kfree(brd->flipbuf);
> +	kfree(brd->flipbuf);
>  
>  	dgnc_Board[brd->boardnum] = NULL;
>  

Sorry, someone else sent this same patch before you did :(



More information about the devel mailing list