[PATCH] staging: ft1000: Replace printk with pr_info in ft1000_cs.c
Tobias Klauser
tklauser at distanz.ch
Wed May 14 08:12:46 UTC 2014
On 2014-05-13 at 16:43:57 +0200, Masanari Iida <standby24x7 at gmail.com> wrote:
> This patch replaced printk with pr_info.
It would be even better to use dev_err(), since these are error messages
and you can use the struct dev from link->dev. You can also drop the
"ft1000:" prefix then.
Cheers
Tobias
>
> Signed-off-by: Masanari Iida <standby24x7 at gmail.com>
> ---
> drivers/staging/ft1000/ft1000-pcmcia/ft1000_cs.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/staging/ft1000/ft1000-pcmcia/ft1000_cs.c b/drivers/staging/ft1000/ft1000-pcmcia/ft1000_cs.c
> index f376ca4..00c86db 100644
> --- a/drivers/staging/ft1000/ft1000-pcmcia/ft1000_cs.c
> +++ b/drivers/staging/ft1000/ft1000-pcmcia/ft1000_cs.c
> @@ -95,20 +95,20 @@ static int ft1000_config(struct pcmcia_device *link)
> /* setup IO window */
> ret = pcmcia_loop_config(link, ft1000_confcheck, NULL);
> if (ret) {
> - printk(KERN_INFO "ft1000: Could not configure pcmcia\n");
> + pr_info("ft1000: Could not configure pcmcia\n");
> return -ENODEV;
> }
>
> /* configure device */
> ret = pcmcia_enable_device(link);
> if (ret) {
> - printk(KERN_INFO "ft1000: could not enable pcmcia\n");
> + pr_info("ft1000: could not enable pcmcia\n");
> goto failed;
> }
>
> link->priv = init_ft1000_card(link, &ft1000_reset);
> if (!link->priv) {
> - printk(KERN_INFO "ft1000: Could not register as network device\n");
> + pr_info("ft1000: Could not register as network device\n");
> goto failed;
> }
>
> --
> 2.0.0.rc3.2.g998f840
>
> _______________________________________________
> devel mailing list
> devel at linuxdriverproject.org
> http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
>
More information about the devel
mailing list