[PATCH 2/5] staging: cxt1e1: remove dead code in musycc.c

Dan Carpenter dan.carpenter at oracle.com
Fri May 9 10:51:49 UTC 2014


On Fri, May 09, 2014 at 07:06:06PM +0900, Daeseok Youn wrote:
> Removes "#if 0" blocks.
> 
> Signed-off-by: Daeseok Youn <daeseok.youn at gmail.com>
> ---
> Dan,
>  I decided to leave musycc_dump_rxbuffer_ring(ch, 0) which is commented
>  out and make a block as "RLD_DEBUG". Because i think this block need to debug
>  with define "RLD_DEBUG". If I am wrong, let me know.
> 

This change should maybe have been in a separate patch.  It's a border
line thing.  But definitely, it should have been mentioned in the
changelog.

Btw, you can use `git citool` to add or remove lines from a
commit.  Highlight and right click on the lines you want to add or
remove.

I don't really care either way if you keep it or delete it.

regards,
dan carpenter



More information about the devel mailing list