[PATCH v2 05/24] staging: comedi: amplc_pci224: use comedi_fc helpers to validate timer args

Ian Abbott abbotti at mev.co.uk
Tue May 6 21:38:55 UTC 2014


On 06/05/14 20:26, H Hartley Sweeten wrote:
> Use the comedi_fc helper cfc_check_trigger_arg_is() to validate the
> scan_begin_arg when the scan_begin_src is TRIG_TIMER.
>
> For aesthetics reasons, rename the local variable 'tmp' to 'arg'.
>
> Signed-off-by: H Hartley Sweeten <hsweeten at visionengravers.com>
> Cc: Ian Abbott <abbotti at mev.co.uk>
> Cc: Greg Kroah-Hartman <gregkh at linuxfoundation.org>
> ---
>
> v2: fix a bug in the TRIG_EXT validation as pointed out by Ian Abbott
>
>   drivers/staging/comedi/drivers/amplc_pci224.c | 28 +++++++++++++--------------
>   1 file changed, 13 insertions(+), 15 deletions(-)

Reviewed-by: Ian Abbott <abbotti at mev.co.uk>

-- 
-=( Ian Abbott @ MEV Ltd.    E-mail: <abbotti at mev.co.uk>        )=-
-=( Tel: +44 (0)161 477 1898   FAX: +44 (0)161 718 3587         )=-


More information about the devel mailing list