[PATCH] checkpatch: Improve missing blank line after declarations test

Andrew Morton akpm at linux-foundation.org
Mon May 5 22:42:38 UTC 2014


On Mon, 05 May 2014 15:35:43 -0700 Joe Perches <joe at perches.com> wrote:

> > @@ -67,6 +68,7 @@ long vfs_truncate(struct path *path, lof
> >  {
> >  	struct inode *inode;
> >  	long error;
> > +	wobble();
> >  
> >  	inode = path->dentry->d_inode;
> 
> Patch content can be a bit odd when lines are
> both added and deleted so checkpatch bleats
> only when both lines are added.
> 
> +	int foo;
> +	wibble();
> 
> generates a complaint.
> 
>  	int foo;
> +	wibble_wobble();
> 
> does not.

Oh, OK.

I have seen no instances of this warning since adding the patch.  So I
guess it's safe to merge but perhaps insufficiently aggressive.  Or
maybe people are being well-behaved.

Oh well, I'll keep an eye out.


More information about the devel mailing list