Found some errors and other oddities, largely by means of a static code analysis program

[Rickard Strandqvist]

Hi

The static code analysis program called cppcheck.
http://cppcheck.sourceforge.net/

I found code that I think are bugs, or at least inappropriate or
unnecessary code, in the files:
drivers/staging/rtl8712/rtl871x_ioctl_linux.c
drivers/staging/rtl8712/rtl871x_mlme.c
drivers/staging/rtl8712/usb_intf.c


I have created a patch, and inluderat the error file generated by cppcheck.

My goal was not to change any functionality, but it does not mean for
example the unused variables can't mean that there are other
problems/mistakes in the code. So a proper code review :)

Is there anything else I can help with regarding the patch or
cppcheck, do not hesitate to contact me.
If you like this type of code analysis, it is possible to get more
warnings, which are not as serious, but that may well indicate other
mistakes.


Best regards
Rickard Strandqvist
-------------- next part --------------
A non-text attachment was scrubbed...
Name: drivers_staging_rtl8712_3files.patch
Type: text/x-patch
Size: 8661 bytes
Desc: not available
URL: <http://driverdev.linuxdriverproject.org/pipermail/driverdev-devel/attachments/20140503/b316f31c/attachment.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: drivers_staging_rtl8712_cppcheck.log
Type: text/x-log
Size: 1524 bytes
Desc: not available
URL: <http://driverdev.linuxdriverproject.org/pipermail/driverdev-devel/attachments/20140503/b316f31c/attachment-0001.bin>