[PATCH] xgifb coding style cleanup

[Aaro Koskinen]

Hi,

On Sun, Mar 30, 2014 at 12:44:59AM -0300, Vitor Braga wrote:
> This fixes "missing a blank line after declaration" warnings from
> checkpatch.pl for driver xgifb. The driver has no remaining errors or
> warnings from checkpatch.pl
> 
> This is my first submission. If there is something wrong, please let me
> know and I'll be glad to fix it.
> 
> Signed-off-by: Vitor Braga <vitorpybraga at gmail.com>

Looks fine.

Reviewed-by: Aaro Koskinen <aaro.koskinen at iki.fi>

A.

> ---
>  drivers/staging/xgifb/XGI_main_26.c | 2 ++
>  drivers/staging/xgifb/vb_init.c     | 2 ++
>  drivers/staging/xgifb/vb_setmode.c  | 2 ++
>  3 files changed, 6 insertions(+)
> 
> diff --git a/drivers/staging/xgifb/XGI_main_26.c b/drivers/staging/xgifb/XGI_main_26.c
> index 46680468..a62d4dd 100644
> --- a/drivers/staging/xgifb/XGI_main_26.c
> +++ b/drivers/staging/xgifb/XGI_main_26.c
> @@ -66,6 +66,7 @@ static int XGIfb_mode_rate_to_dclock(struct vb_device_info *XGI_Pr,
>  	unsigned short ModeIdIndex = 0, ClockIndex = 0;
>  	unsigned short RefreshRateTableIndex = 0;
>  	int Clock;
> +
>  	InitTo330Pointer(HwDeviceExtension->jChipType, XGI_Pr);
>  
>  	XGI_SearchModeID(ModeNo, &ModeIdIndex);
> @@ -95,6 +96,7 @@ static int XGIfb_mode_rate_to_ddata(struct vb_device_info *XGI_Pr,
>  	unsigned short HRE, HBE, HRS, HDE;
>  	unsigned char sr_data, cr_data, cr_data2;
>  	int B, C, D, F, temp, j;
> +
>  	InitTo330Pointer(HwDeviceExtension->jChipType, XGI_Pr);
>  	if (!XGI_SearchModeID(ModeNo, &ModeIdIndex))
>  		return 0;
> diff --git a/drivers/staging/xgifb/vb_init.c b/drivers/staging/xgifb/vb_init.c
> index 2154172..ff210dd 100644
> --- a/drivers/staging/xgifb/vb_init.c
> +++ b/drivers/staging/xgifb/vb_init.c
> @@ -130,6 +130,7 @@ static void XGINew_DDRII_Bootup_XG27(
>  			unsigned long P3c4, struct vb_device_info *pVBInfo)
>  {
>  	unsigned long P3d4 = P3c4 + 0x10;
> +
>  	pVBInfo->ram_type = XGINew_GetXG20DRAMType(HwDeviceExtension, pVBInfo);
>  	XGINew_SetMemoryClock(pVBInfo);
>  
> @@ -389,6 +390,7 @@ static void XGI_SetDRAM_Helper(unsigned long P3d4, u8 seed, u8 temp2, u8 reg,
>  	u8 shift_factor, u8 mask1, u8 mask2)
>  {
>  	u8 j;
> +
>  	for (j = 0; j < 4; j++) {
>  		temp2 |= (((seed >> (2 * j)) & 0x03) << shift_factor);
>  		xgifb_reg_set(P3d4, reg, temp2);
> diff --git a/drivers/staging/xgifb/vb_setmode.c b/drivers/staging/xgifb/vb_setmode.c
> index 400c726..c638c8f 100644
> --- a/drivers/staging/xgifb/vb_setmode.c
> +++ b/drivers/staging/xgifb/vb_setmode.c
> @@ -49,6 +49,7 @@ void InitTo330Pointer(unsigned char ChipType, struct vb_device_info *pVBInfo)
>  
>  	if (ChipType == XG27) {
>  		unsigned char temp;
> +
>  		pVBInfo->MCLKData = XGI27New_MCLKData;
>  		pVBInfo->CR40 = XGI27_cr41;
>  		pVBInfo->XGINew_CR97 = 0xc1;
> @@ -5222,6 +5223,7 @@ void XGI_SenseCRT1(struct vb_device_info *pVBInfo)
>  	unsigned short temp;
>  
>  	int i;
> +
>  	xgifb_reg_set(pVBInfo->P3c4, 0x05, 0x86);
>  
>  	/* to fix XG42 single LCD sense to CRT+LCD */
> -- 
> 1.9.0
> 
> 
> -- 
> Vitor
> _______________________________________________
> devel mailing list
> devel at linuxdriverproject.org
> http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel