[staging:staging-next 122/153] drivers/staging/slicoss/slicoss.c:1429 slic_cmdq_addcmdpage() error: we previously assumed 'pslic_handle' could be null (see line 1425)

[Dan Carpenter]

Hi Monam,

FYI, there are new smatch warnings show up in

tree:   git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/staging.git staging-next
head:   7b99b5efaab0f8c8c637cb68840e990fbca16878
commit: b0a0fb1e292e1472db7aea8ddce2fc5ceae5ab48 [122/153] Staging: slicoss: Replace macro with inline defination in slicoss.c

drivers/staging/slicoss/slicoss.c:1429 slic_cmdq_addcmdpage() error: we previously assumed 'pslic_handle' could be null (see line 1425)

git remote add staging git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/staging.git
git remote update staging
git checkout b0a0fb1e292e1472db7aea8ddce2fc5ceae5ab48
vim +/pslic_handle +1429 drivers/staging/slicoss/slicoss.c

4d6ea9c3 Denis Kirjanov 2010-07-10  1419  	while ((cmdcnt < SLIC_CMDQ_CMDSINPAGE) &&
4d6ea9c3 Denis Kirjanov 2010-07-10  1420  	       (adapter->slic_handle_ix < 256)) {
4d6ea9c3 Denis Kirjanov 2010-07-10  1421  		/* Allocate and initialize a SLIC_HANDLE for this command */
b0a0fb1e Monam Agarwal  2014-03-09  1422  		spin_lock_irqsave(&adapter->handle_lock.lock,
b0a0fb1e Monam Agarwal  2014-03-09  1423  				adapter->handle_lock.flags);
b0a0fb1e Monam Agarwal  2014-03-09  1424  		pslic_handle  =  adapter->pfree_slic_handles;
b0a0fb1e Monam Agarwal  2014-03-09 @1425  		if (pslic_handle)
b0a0fb1e Monam Agarwal  2014-03-09  1426  			adapter->pfree_slic_handles = pslic_handle->next;
b0a0fb1e Monam Agarwal  2014-03-09  1427  		spin_unlock_irqrestore(&adapter->handle_lock.lock,
b0a0fb1e Monam Agarwal  2014-03-09  1428  				adapter->handle_lock.flags);
4d6ea9c3 Denis Kirjanov 2010-07-10 @1429  		pslic_handle->type = SLIC_HANDLE_CMD;
4d6ea9c3 Denis Kirjanov 2010-07-10  1430  		pslic_handle->address = (void *) cmd;
4d6ea9c3 Denis Kirjanov 2010-07-10  1431  		pslic_handle->offset = (ushort) adapter->slic_handle_ix++;
4d6ea9c3 Denis Kirjanov 2010-07-10  1432  		pslic_handle->other_handle = NULL;

---
0-DAY kernel build testing backend              Open Source Technology Center
http://lists.01.org/mailman/listinfo/kbuild                 Intel Corporation