[RFC PATCH 03/22] staging: crypto: skein: allow building statically

Jason Cooper jason at lakedaemon.net
Tue Mar 18 12:58:49 UTC 2014

On Mon, Mar 17, 2014 at 02:52:52PM -0700, Greg KH wrote:
> On Tue, Mar 11, 2014 at 09:32:35PM +0000, Jason Cooper wrote:
> > These are the minimum changes required to get the code to build
> > statically in the kernel.  It's necessary to do this first so that we
> > can empirically determine that future cleanup patches aren't changing
> > the generated object code.
> > 
> > Signed-off-by: Jason Cooper <jason at lakedaemon.net>
> This doesn't apply to my latest tree :(

Ah, ok.  I'll rebase this series on the staging tree.

> > --- a/drivers/staging/Makefile
> > +++ b/drivers/staging/Makefile
> > @@ -65,3 +65,4 @@ obj-$(CONFIG_XILLYBUS)		+= xillybus/
> >  obj-$(CONFIG_DGNC)			+= dgnc/
> >  obj-$(CONFIG_DGAP)			+= dgap/
> >  obj-$(CONFIG_MTD_SPINAND_MT29F)	+= mt29f_spinand/
> > +obj-$(CONFIG_CRYPTO_SKEIN) += skein/
> Care to align these up with the way this file is formatted?

Of course, not sure what happened there (well, other than the obvious

> And I have no objection to taking the drivers/staging/ patches, the
> script looks useful, but I can't take it through the staging tree,
> sorry.

Ok, I'll pull that out as a separate branch.  Do you mind taking a
series that depends on a topic branch from another tree?  We do it a lot
in arm-soc, but I'm not sure how popular that is elsewhere.

It's purely an audit/testing dependency, but it would be nice to have it
available in the history if someone wants to audit the changes.

I have one change I'd like to do to the objdiff script.  I'd like it to
assume 'HEAD^ HEAD' when the user executes './scripts/objdiff diff'.

I'll respin both and submit a v1.

Thanks for the review.



More information about the devel mailing list