[PATCH] staging: comedi: das6402: rewrite broken driver

Ian Abbott abbotti at mev.co.uk
Mon Mar 17 13:56:39 UTC 2014


On 2014-03-14 19:24, H Hartley Sweeten wrote:
> This driver is _really_ broken.
>
> It initializes an analog input subdevice that only has a (*cancel)
> function. It also does a request_irq() to hookup an interrupt handler
> using it->options[0] as the IRQ. This option is actually the base
> address of the I/O region used by the board. If the interrupt handler
> actually did get hooked up, the rest of the code assumes that IRQ 10
> is being used.
>
> Rewrite the driver to properly support the hardware.
>
> The DAS6402-12/16 boards have 64 single-ended / 32 differential analog
> inputs, 2 analog outputs, 8 digital inputs, and 8 digital outputs. Add
> proper support for these subdevices.
>
> Stub in the analog input async command support.
>
> Signed-off-by: H Hartley Sweeten <hsweeten at visionengravers.com>
> Cc: Ian Abbott <abbotti at mev.co.uk>
> Cc: Greg Kroah-Hartman <gregkh at linuxfoundation.org>

I guess it won't have been run-tested, but it can't be worse than the 
old one!

Reviewed-by: Ian Abbott <abbotti at mev.co.uk>

-- 
-=( Ian Abbott @ MEV Ltd.    E-mail: <abbotti at mev.co.uk>        )=-
-=( Tel: +44 (0)161 477 1898   FAX: +44 (0)161 718 3587         )=-


More information about the devel mailing list