[PATCH v3 1/2] Staging: comedi: addi-data: Fix long CamelCase function names

Ian Abbott abbotti at mev.co.uk
Wed Mar 12 17:48:52 UTC 2014


On 2014-03-12 01:06, Hartley Sweeten wrote:
> On Tuesday, March 11, 2014 3:19 PM, Fred Akers wrote:
>> This patch fixes a few function names that are very long and are
>> not in the correct naming style
>>
>> Signed-off-by: Fred Akers <knivey at botops.net>
>
> Fred,
>
> I pulled Greg's staging tree to see if your patches apply.
>
> Patch 1/2 is ok but patch 2/2 does not apply:
>
> Applying: Staging: Comedi: addi-data: Clean up function comments
> error: patch failed: drivers/staging/comedi/drivers/addi-data/hwdrv_apci035.c:1
> error: drivers/staging/comedi/drivers/addi-data/hwdrv_apci035.c: patch does not apply
> error: patch failed: drivers/staging/comedi/drivers/addi-data/hwdrv_apci1500.c:1
> error: drivers/staging/comedi/drivers/addi-data/hwdrv_apci1500.c: patch does not apply
> error: patch failed: drivers/staging/comedi/drivers/addi-data/hwdrv_apci1564.c:1
> error: drivers/staging/comedi/drivers/addi-data/hwdrv_apci1564.c: patch does not apply
> Patch failed at 0001 Staging: Comedi: addi-data: Clean up function comments
>
> Maybe Greg will have better luck.
>
> Regards,
> Hartley
>

FWIW, I managed to apply them, but mainly because our internal MS 
Exchange server (which often messes up patches) is down, so I'm having 
to deliver the mail to a "proper" mail server. :)

(Also, the patches in the driverdev-devel archive don't apply as-is, 
partly because it replaces '@' with ' at ', and partly because it 
replaces the ezsett character in 'Dieselstraße' with a question mark '?'.)

-- 
-=( Ian Abbott @ MEV Ltd.    E-mail: <abbotti at mev.co.uk>        )=-
-=( Tel: +44 (0)161 477 1898   FAX: +44 (0)161 718 3587         )=-



More information about the devel mailing list