[PATCH V3 0/6] Drivers: net: hyperv: Enable various offloads

[KY Srinivasan]

> -----Original Message-----
> From: David Miller [mailto:davem at davemloft.net]
> Sent: Tuesday, March 11, 2014 1:26 AM
> To: KY Srinivasan
> Cc: netdev at vger.kernel.org; linux-kernel at vger.kernel.org;
> devel at linuxdriverproject.org; olaf at aepfle.de; apw at canonical.com;
> jasowang at redhat.com
> Subject: Re: [PATCH V3 0/6] Drivers: net: hyperv: Enable various offloads
> 
> From: "K. Y. Srinivasan" <kys at microsoft.com>
> Date: Sat,  8 Mar 2014 19:22:42 -0800
> 
> > This patch set enables both checksum as well as segmentation offload.
> > As part of this effort I have enabled scatter gather I/O a well.
> >
> > In version 2 of these patches, I addressed comments from David Miller
> > and Dan Carpenter.
> >
> > In this version I have addressed the latest comments from David Miller.
> 
> Series applied, thanks.
> 
> I still think that fill_pg_buf() could be improved.
> 
> For example, it returns '1' if len is passed in as zero.  Maybe that can't
> happen, but if it does the page buffer array will be corrupted and the driver
> will process garbage.
> 
> It seems so much more straightforward to me if you simply incremented 'j' in
> the loop when an array entry is actually filled in.  Then just return 'j'.
> 
> 	int j; 
>  ...
> 		pb[j].pfn = page_to_pfn(page);
> 		pb[j].offset = offset;
> 		pb[j].len = bytes;
> 		j++;
>  ...
> 	return j;
> 
> 
> Then 'j' is unambiguously the number of pb array entries which were filled in,
> no matter what.
Thanks David. As you suggest, I will send a patch to make this cleaner.

Regards,

K. Y