[PATCH 1/1] staging: unisys: Fix MAINTAINERS

Romer, Benjamin M Benjamin.Romer at unisys.com
Fri Mar 7 14:51:37 UTC 2014


On Fri, 2014-03-07 at 17:41 +0300, Dan Carpenter wrote:
> On Fri, Mar 07, 2014 at 08:18:44AM -0600, Romer, Benjamin M wrote:
> > 
> > On Thu, 2014-03-06 at 12:01 -0800, gregkh at linuxfoundation.org wrote:
> > > On Thu, Mar 06, 2014 at 10:01:04AM -0600, Romer, Benjamin M wrote:
> > > > This patch updates the MAINTAINERS file to add the maintainer for the
> > > > Unisys s-Par driver set.
> > > > 
> > > > Signed-off-by: Ken Cox <jkc at redhat.com>
> > > > signed-off-by: Ben Romer <sparmaintainer at unisys.com>
> > > 
> > > Please capitalize things properly.
> > > 
> > > And your From: address does not match your "Signed-off-by:" line.  Why
> > > are you trying to use an "alias" as a maintainer or a sign-off?  We want
> > > a "real" address / name please, especially as it's obvious you have one :)
> > > 
> > > thanks,
> > > 
> > > greg k-h
> > 
> > The email address I listed is a group address - I'll change the contents of the file
> > so they more accurately describe how we've set things up.
> 
> The file is fine (I think).
> 
> Signed-off-by is like signing a legal document.  You should sign on your
> own behalf and not for a group of people.  And if the Signed-off-by
> doesn't match your From then how do we know it's really you?
> 
> regards,
> dan carpenter
> 

That's what I mean though, the file isn't quite accurate.
sparmaintainer at unisys.com is a group email address for which I'm the
primary contact, but there are other developers and managers with access
to it. I'll list myself and one other person by email address for
handling patches, and put the group address as the mailing list entry. 

Also, the file should say "Supported" instead of "Maintained", so that
wasn't quite right either. :)



More information about the devel mailing list