[PATCH] checkpatch: net and drivers/net: Warn on missing blank line after variable declaration
Andrew Morton
akpm at linux-foundation.org
Thu Mar 6 23:35:30 UTC 2014
On Thu, 06 Mar 2014 15:28:40 -0800 Joe Perches <joe at perches.com> wrote:
> Networking prefers this style, so warn when it's not used.
>
> Networking uses:
>
> void foo(int bar)
> {
> int baz;
>
> code...
> }
>
> not
>
> void foo(int bar)
> {
> int baz;
> code...
> }
>
> There are a limited number of false positives when using
> macros to declare variables like:
>
> WARNING: networking uses a blank line after declarations
> #330: FILE: net/ipv4/inet_hashtables.c:330:
> + int dif = sk->sk_bound_dev_if;
> + INET_ADDR_COOKIE(acookie, saddr, daddr)
um wait wut wot.
*All* kernel code uses blank line between end-of-locals and
start-of-code. Or if it doesn't it should, thwap.
Why are we special-casing net/?
More information about the devel
mailing list