[PATCH 2/2] lustre/lov_obd: fix possible null pointer dereference
Greg KH
gregkh at linuxfoundation.org
Thu Mar 6 19:53:56 UTC 2014
On Wed, Mar 05, 2014 at 02:04:36PM +0100, Maxin B. John wrote:
> From: "Maxin B. John" <maxin.john at enea.com>
>
> osc_obd can be NULL. cppcheck reported this:
> [lustre/lustre/lov/lov_obd.c:283]: (error) Possible null pointer dereference:
> osc_obd - otherwise it is redundant to check if osc_obd is null at line 295
Same problem, osc_obd can never be NULL, please be more careful with
your patches, and just remove pointless tests instead of papering over
them with patches like this.
thanks.
greg k-h
More information about the devel
mailing list