[PATCH 02/03] staging: dgap: fix a few more 80+ lines as reported by checkpatch

Dan Carpenter dan.carpenter at oracle.com
Wed Mar 5 21:47:10 UTC 2014


On Wed, Mar 05, 2014 at 03:54:50PM -0500, Mark Hounschell wrote:
> @@ -2953,7 +2955,8 @@ static int dgap_tty_write(struct tty_struct *tty, const unsigned char *buf, int
>  		if (down_interruptible(&dgap_TmpWriteSem))
>  			return -EINTR;
>  
> -		if (copy_from_user(dgap_TmpWriteBuf, (const uchar __user *) buf, count)) {
> +		if (copy_from_user(dgap_TmpWriteBuf, (const uchar __user *)buf,
> +					count)) {
>  			up(&dgap_TmpWriteSem);
>  			return -EFAULT;
>  		}

This is dead code btw.  "from_user" is always false.

regards,
dan carpenter


More information about the devel mailing list