[patch V2 1/8] staging: visorutil driver to provide common functionality to other s-Par drivers

Greg KH gregkh at linuxfoundation.org
Wed Mar 5 00:54:58 UTC 2014


On Tue, Mar 04, 2014 at 07:58:05AM -0600, Ken Cox wrote:
> +EXPORT_SYMBOL_GPL(proc_CreateType);

You have some _very_ generic symbols that you are now exporting.

Here's another funny one:

> +int hexDumpWordsToBuffer(char *dest,
> +			 int destSize,
> +			 char *prefix,
> +			 uint32_t *src,
> +			 int srcWords,
> +			 int wordsToDumpPerLine)

Be prepared to be forced to make these drivers a module after the 0-day
build system throws up on this stuff...

good luck :)

greg k-h


More information about the devel mailing list