[PATCH 00/66] staging: comedi: cleanup pcl812/816/818 drivers part 2

[Ian Abbott]

On 03/03/14 21:19, Hartley Sweeten wrote:
> On Monday, March 03, 2014 11:17 AM, Ian Abbott wrote:
>> On 2014-02-28 23:23, H Hartley Sweeten wrote:
>>> This series continues the cleanup of the pcl812/816/818 drivers.
>>>
>>> H Hartley Sweeten (66):
>>
>> I've looked through them all now.  I have noted likely problems with
>> patches 13 and 19, although the code in patch 13 doesn't seem to be
>> reachable.
>
> Ian,
>
> I can fix patch 19 and the rest of the series applies with no problems.
>
> If I drop patch 13 the series starts falling having issues at patch 15.
>
> Would you like me to drop patch 13 and rebase the series or just post
> an updated patch 19 and apply patch 13 as-is?

I feel it's better to drop patch 13, even though it's a bit of a pain, 
to avoid leaving non-working code in the tree (even though it is 
currently unreachable).

It would be nice to drop command support in pcl816 if there is no DMA 
channel, since it's currently broken due to the switch in 
pcl816_ai_cmd() always picking one of the DMA transfer modes even if DMA 
isn't being used!

-- 
-=( Ian Abbott @ MEV Ltd.    E-mail: <abbotti at mev.co.uk>        )=-
-=( Tel: +44 (0)161 477 1898   FAX: +44 (0)161 718 3587         )=-