[PATCH 4/7] staging: cxt1e1: fix checkpatch error 'assignment in if condition'

Dan Carpenter dan.carpenter at oracle.com
Tue Mar 4 09:04:19 UTC 2014


On Tue, Mar 04, 2014 at 11:09:39AM +0900, Daeseok Youn wrote:
> @@ -1174,7 +1179,8 @@ cleanup_hdlc(void)
>  			ci = (ci_t *)(netdev_priv(hi->ndev));
>  			for (j = 0; j < ci->max_port; j++)
>  				for (k = 0; k < MUSYCC_NCHANS; k++)
> -					if ((ndev = ci->port[j].chan[k]->user))
> +					ndev = ci->port[j].chan[k]->user;
> +					if (ndev)
>  					{
>  						do_deluser(ndev, 0);
>  					}


This patch introduces a bug here because the inner for loop now has two
statement but no curly braces.

regards,
dan carpenter


More information about the devel mailing list