[PATCH 3/9] drivers: staging: rtl8187se: wrap excessively long lines

Dan Carpenter dan.carpenter at oracle.com
Mon Mar 3 08:58:47 UTC 2014


Patch introduces bugs.  Please redo and be more careful next time.

On Sat, Mar 01, 2014 at 10:22:47PM -0700, Axel Rasmussen wrote:
> Signed-off-by: Axel Rasmussen <axel.rasmussen1 at gmail.com>
> @@ -935,7 +946,8 @@ static short alloc_rx_desc_ring(struct net_device *dev, u16 bufsize, int count)
>  		tmp = tmp+rx_desc_size;
>  	}
>  
> -	*(tmp-rx_desc_size) = *(tmp-rx_desc_size) | (1<<30); /* this is the last descriptor */
> +	/* this is the last descriptor */
> +	*(tmp - rx_desc_size) = (*tmp-rx_desc_size) | (1 << 30);

You changed "*(tmp-rx_desc_size)" to "(*tmp-rx_desc_size)".

regards,
dan carpenter



More information about the devel mailing list