[PATCH 07/08] staging:dgap: Fix externs should be avoided in .c files as reported by checkpatch

Mark Hounschell markh at compro.net
Sat Mar 1 09:57:31 UTC 2014


On 02/28/2014 05:59 PM, Greg KH wrote:
> On Fri, Feb 28, 2014 at 12:42:14PM -0500, Mark Hounschell wrote:
>> This patch fixes "externs should be avoided in .c files"
>> in dgap.c as reported by checkpatch
>>
>> Signed-off-by: Mark Hounschell <markh at compro.net>
>> ---
>>   drivers/staging/dgap/dgap.c | 8 ++++----
>>   1 file changed, 4 insertions(+), 4 deletions(-)
>>
>> diff --git a/drivers/staging/dgap/dgap.c b/drivers/staging/dgap/dgap.c
>> index cfa33f9..b3f8c49 100644
>> --- a/drivers/staging/dgap/dgap.c
>> +++ b/drivers/staging/dgap/dgap.c
>> @@ -224,8 +224,8 @@ static void dgap_sysfs_create(struct board_t *brd);
>>   static int dgap_firmware_load(struct pci_dev *pdev, int card_type);
>>
>>   /* Driver load/unload functions */
>> -int			dgap_init_module(void);
>> -void			dgap_cleanup_module(void);
>> +static int dgap_init_module(void);
>> +static void dgap_cleanup_module(void);
>>
>>   module_init(dgap_init_module);
>>   module_exit(dgap_cleanup_module);
>
> If you just move these module_* lines to the bottom of the file, you
> shouldn't need the function prototype at all, right?
>
> Care to make that change here instead?
>
> thanks,

I will rework this one.

thanks
Mark



More information about the devel mailing list