[PATCH 067/115] staging: ced1401: fix ced_read_char()

Luca Ellero luca.ellero at brickedbrain.com
Mon Jun 30 10:00:59 UTC 2014


Rename camel case arguments and locals in function ced_read_char()

Signed-off-by: Luca Ellero <luca.ellero at brickedbrain.com>
---
 drivers/staging/ced1401/usb1401.c |   23 ++++++++++++-----------
 1 file changed, 12 insertions(+), 11 deletions(-)

diff --git a/drivers/staging/ced1401/usb1401.c b/drivers/staging/ced1401/usb1401.c
index 8007085..17d1c60 100644
--- a/drivers/staging/ced1401/usb1401.c
+++ b/drivers/staging/ced1401/usb1401.c
@@ -937,20 +937,21 @@ int ced_read_write_mem(struct ced_data *ced, bool read, unsigned short ident,
 **  data we return FALSE. Used as part of decoding a DMA request.
 **
 ****************************************************************************/
-static bool ced_read_char(unsigned char *pChar, char *pBuf, unsigned int *pdDone,
-		     unsigned int dGot)
+static bool ced_read_char(unsigned char *character, char *buf,
+			  unsigned int *n_done, unsigned int got)
 {
-	bool bRead = false;
-	unsigned int dDone = *pdDone;
-
-	if (dDone < dGot) {	/*  If there is more data */
-		*pChar = (unsigned char)pBuf[dDone];	/*  Extract the next char */
-		dDone++;	/*  Increment the done count */
-		*pdDone = dDone;
-		bRead = true;	/*  and flag success */
+	bool read = false;
+	unsigned int done = *n_done;
+
+	if (done < got) {	/* If there is more data */
+		/* Extract the next char */
+		*character = (unsigned char)buf[done];
+		done++;	/* Increment the done count */
+		*n_done = done;
+		read = true;	/* and flag success */
 	}
 
-	return bRead;
+	return read;
 }
 
 #ifdef NOTUSED
-- 
1.7.10.4



More information about the devel mailing list