[PATCH 1/4] Staging: unisys: remove references to __DATE__ and __TIME__

Ken Cox jkc at redhat.com
Thu Jun 26 10:37:35 UTC 2014


On 06/25/2014 10:57 PM, Greg KH wrote:
> On Wed, Jun 25, 2014 at 11:48:23AM -0500, Ken Cox wrote:
--snip--
>>   	.id_table = virthba_id_table,
>>   	.probe = virthba_probe,
>>   	.remove = virthba_remove,
>> @@ -1413,9 +1413,6 @@ info_proc_read(struct file *file, char __user *buf, size_t len, loff_t *offset)
>>   		length += sprintf(vbuf + length, "\nvirthba result queue poll wait:%d usecs.\n",
>>   				  rsltq_wait_usecs);
>>   
>> -		length += sprintf(vbuf + length,
>> -				  "\nModule build: Date:%s Time:%s\n",
>> -				  __DATE__, __TIME__);
>>   		length += sprintf(vbuf + length, "\ninterrupts_rcvd = %llu, interrupts_disabled = %llu\n",
>>   				  virthbainfo->interrupts_rcvd,
>>   				  virthbainfo->interrupts_disabled);
> Why not just delete this proc file entirely?  You'll have to do that
> eventually anyway :)
Ben Romer is working on a patch set to remove all the proc files for the 
Unisys drivers.  He is travelling right now but I think he will be 
submitting it in the next few days.  Is it ok to leave this for now and 
let his patches remove all proc entries at the same time?



More information about the devel mailing list