[PATCH] Staging: unisys Remove BROKEN from Kconfig to allow compilation

Greg KH gregkh at linuxfoundation.org
Mon Jun 23 15:19:15 UTC 2014


On Mon, Jun 23, 2014 at 09:12:32AM -0500, Ken Cox wrote:
> 
> On 06/17/2014 05:49 PM, Greg KH wrote:
> >On Tue, Jun 03, 2014 at 09:43:35AM -0500, Ken Cox wrote:
> >>The unisys drivers now properly check to make sure they are running
> >>on the s-Par platform before they will initialize.  This was fixed in
> >>commit fcd0157ece so it is safe to allow the unisys drivers to be built.
> >>
> >>This has been tested in the same qemu environment that originally
> >>produced the panic and the kernel now runs as expected.
> >It hasn't been tested on a build, as this breaks the build on my machine
> >in tons of horrible ways (hint __DATE__ and __TIME__ are no longer
> >allowed in kernel code...)
> Sorry for the delay in responding.  I have been travelling the last week or
> so.
> 
> I understand the problem with __DATE__ and __TIME__, but I think I may be
> missing something.
> 
> Does this cause a failure to build for you?

Yes it does.

> I built it before I sent the patch and I just pulled your latest
> staging-next changes and built with no errors.  I want to make sure I
> address the problem you are seeing.

You might have built it against an older kernel version, or with an
older version of gcc.

greg k-h


More information about the devel mailing list