[PATCH] staging: ced1401: userspace: use1401.c: Cleaning up potential strncpy missing null-terminate

Rickard Strandqvist rickard_strandqvist at spectrumdigital.se
Mon Jun 16 22:14:18 UTC 2014


2014-06-16 21:09 GMT+02:00 Dan Carpenter <dan.carpenter at oracle.com>:
> On Mon, Jun 16, 2014 at 10:01:14PM +0300, Dan Carpenter wrote:
>>
>> No one calls U14DriverName() so just delete this function.
>
> Oh.  This is a userspace library or something?  I'm not sure what to do.
>
> How did you compile test this?  Does your platform even provide
> strlcpy()?
>
> Anyway, don't delete it like I said, but I still don't think your patch
> helps here.
>
> regards,
> dan carpenter
>

Hi

I saw that these functions are not used, had planned type it in the
cover letter to :-(

Thought of userspec, but then it should definitely ensure the NULL char?

Kind regards
Rickard Strandqvist


More information about the devel mailing list