[PATCH v2 1/2] drivers/staging/usbip/userspace/libsrc/usbip_host_driver.c: fix coding style

Joe Perches joe at perches.com
Thu Jun 12 17:55:14 UTC 2014


On Thu, 2014-06-12 at 10:54 -0700, Greg Kroah-Hartman wrote:
> On Thu, Jun 12, 2014 at 09:32:19PM +0400, Wahib Faizi wrote:
> > Fix coding style issue "do not use assignment in if condition"
> > detected by checkpatch.pl in usbip_host_driver.c.
> > 
> > Signed-off-by: Wahib Faizi <wahibfaizi at gmail.com>
> 
> Both of these patches have the same Subject: line, which isn't good as
> it doesn't make much sense.
> 
> You can also shorten it a lot, for example, this one should be:
>   Subject: staging: usbip: usbip_host_driver.c: fix if assignment style issue

True.  usbip_host_driver.c doesn't add much though.

It could even be something like:

staging: usbip: avoid assignment in if




More information about the devel mailing list