[PATCH] list: Fix order of arguments for hlist_add_after(_rcu)

Greg KH greg at kroah.com
Fri Jun 6 15:50:12 UTC 2014


On Fri, Jun 06, 2014 at 11:42:23AM +0200, Ken Helias wrote:
> All other add functions for lists have the new item as first argument and the
> position where it is added as second argument. This was changed for no good
> reason in this function and makes using it unnecessary confusing.
> 
> Also the naming of the arguments in hlist_add_after was confusing. It was
> changed to use the same names as hlist_add_after_rcu.
> 
> Signed-off-by: Ken Helias <kenhelias at firemail.de>
> Cc: David Airlie <airlied at linux.ie>
> Cc: Jeff Kirsher <jeffrey.t.kirsher at intel.com>
> Cc: Jesse Brandeburg <jesse.brandeburg at intel.com>
> Cc: Bruce Allan <bruce.w.allan at intel.com>
> Cc: Carolyn Wyborny <carolyn.wyborny at intel.com>
> Cc: Don Skidmore <donald.c.skidmore at intel.com>
> Cc: Greg Rose <gregory.v.rose at intel.com>
> Cc: Alex Duyck <alexander.h.duyck at intel.com>
> Cc: John Ronciak <john.ronciak at intel.com>
> Cc: Mitch Williams <mitch.a.williams at intel.com>
> Cc: Linux NICS <linux.nics at intel.com>
> Cc: Alexander Viro <viro at zeniv.linux.org.uk>
> Cc: Dipankar Sarma <dipankar at in.ibm.com>
> Cc: "Paul E. McKenney" <paulmck at linux.vnet.ibm.com>
> Cc: Marek Lindner <mareklindner at neomailbox.ch>
> Cc: Simon Wunderlich <sw at simonwunderlich.de>
> Cc: Antonio Quartulli <antonio at meshcoding.com>
> Cc: "David S. Miller" <davem at davemloft.net>
> Cc: Stephen Hemminger <stephen at networkplumber.org>
> Cc: Alexey Kuznetsov <kuznet at ms2.inr.ac.ru>
> Cc: James Morris <jmorris at namei.org>
> Cc: Hideaki YOSHIFUJI <yoshfuji at linux-ipv6.org>
> Cc: Patrick McHardy <kaber at trash.net>
> Cc: Steffen Klassert <steffen.klassert at secunet.com>
> Cc: Herbert Xu <herbert at gondor.apana.org.au>
> Cc: dri-devel at lists.freedesktop.org
> Cc: e1000-devel at lists.sourceforge.net
> Cc: netdev at vger.kernel.org
> Cc: devel at driverdev.osuosl.org
> Cc: linux-fsdevel at vger.kernel.org
> Cc: b.a.t.m.a.n at lists.open-mesh.org
> Cc: bridge at lists.linux-foundation.org
> ---
> Patch based on "Add linux-next specific files for 20140606"
> 
>  drivers/gpu/drm/drm_hashtab.c                    |  2 +-
>  drivers/net/ethernet/intel/i40e/i40e_ethtool.c   |  2 +-
>  drivers/net/ethernet/intel/ixgbe/ixgbe_ethtool.c |  2 +-
>  drivers/staging/lustre/lustre/libcfs/hash.c      |  4 ++--
>  fs/namespace.c                                   |  2 +-
>  fs/notify/inode_mark.c                           |  2 +-
>  fs/notify/vfsmount_mark.c                        |  2 +-
>  include/linux/list.h                             | 12 ++++++------
>  include/linux/rculist.h                          |  6 +++---
>  net/batman-adv/fragmentation.c                   |  2 +-
>  net/bridge/br_multicast.c                        |  2 +-
>  net/ipv4/fib_trie.c                              |  2 +-
>  net/ipv6/addrlabel.c                             |  2 +-
>  net/xfrm/xfrm_policy.c                           |  4 ++--
>  14 files changed, 23 insertions(+), 23 deletions(-)


drivers/staging/ portion:
	Acked-by: Greg Kroah-Hartman <gregkh at linuxfoundation.org>


More information about the devel mailing list