[PATCH] staging: comedi: style - use kmalloc_array(n, s, ...) instead of kmalloc(n*s, ...)

Ian Abbott abbotti at mev.co.uk
Tue Jun 3 11:40:46 UTC 2014


On 2014-06-02 21:48, Wolfgang Ocker wrote:
> Fix a style issue reported by checkpatch.pl for the Eudyptula challenge
>
> Signed-off-by: Wolfgang Ocker <weo at weo1.de>
> ---
>   drivers/staging/comedi/comedi_fops.c | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/staging/comedi/comedi_fops.c b/drivers/staging/comedi/comedi_fops.c
> index 9d99fb3..c54ed42 100644
> --- a/drivers/staging/comedi/comedi_fops.c
> +++ b/drivers/staging/comedi/comedi_fops.c
> @@ -1295,7 +1295,7 @@ static int do_insnlist_ioctl(struct comedi_device *dev,
>   	if (copy_from_user(&insnlist, arg, sizeof(insnlist)))
>   		return -EFAULT;
>
> -	data = kmalloc(sizeof(unsigned int) * MAX_SAMPLES, GFP_KERNEL);
> +	data = kmalloc_array(MAX_SAMPLES, sizeof(unsigned int), GFP_KERNEL);
>   	if (!data) {
>   		ret = -ENOMEM;
>   		goto error;
> @@ -1376,7 +1376,7 @@ static int do_insn_ioctl(struct comedi_device *dev,
>   	unsigned int *data = NULL;
>   	int ret = 0;
>
> -	data = kmalloc(sizeof(unsigned int) * MAX_SAMPLES, GFP_KERNEL);
> +	data = kmalloc_array(MAX_SAMPLES, sizeof(unsigned int), GFP_KERNEL);
>   	if (!data) {
>   		ret = -ENOMEM;
>   		goto error;
>

I couldn't reproduce the checkpatch.pl style issue with "subjective" 
tests turned on, but it seems a harmless enough change.

Reviewed-by: Ian Abbott <abbotti at mev.co.uk>

-- 
-=( Ian Abbott @ MEV Ltd.    E-mail: <abbotti at mev.co.uk>        )=-
-=( Tel: +44 (0)161 477 1898   FAX: +44 (0)161 718 3587         )=-


More information about the devel mailing list