[PATCH] staging/media/rtl2832u_sdr: fix coding style problems by adding blank lines

Dan Carpenter dan.carpenter at oracle.com
Mon Jun 2 21:33:01 UTC 2014


On Mon, Jun 02, 2014 at 12:50:35PM -0700, Ovidiu Toader wrote:
> On 06/02/14 03:21, Dan Carpenter wrote:
> > Send the patch inline, not as an attachment.
> > 
> > Read the first paragraph.
> > https://git.kernel.org/cgit/linux/kernel/git/next/linux-next.git/tree/Documentation/email-clients.txt
> > 
> > The subject should say something about adding blank lines.
> Thanks for the feedback and sorry for the inconvenience.
> Take 2:
> 
> This minor patch fixes all WARNING:SPACING style warnings in rtl2832_sdr.c
> 
> The new version of the file pleases checkpatch.pl when run with "--ignore LONG_LINE".
> 

Better but not quite right.  You understand that the email *is* the
changelog?  So now it has our conversation saved in the changelog for
all time.

https://www.google.com/search?q=how+to+send+a+v2+patch

regards,
dan carpenter



More information about the devel mailing list