[PATCH 1/1] staging: rtl8192u: mark some functions as static.

Antoine Schweitzer-Chaput antoine at schweitzer-chaput.fr
Thu Jul 31 21:11:31 UTC 2014


On Wed, Jul 30, 2014 at 05:06:41PM -0700, Greg Kroah-Hartman wrote:
> On Mon, Jul 28, 2014 at 05:52:46PM +0200, Antoine Schweitzer-Chaput wrote:
> > Some functions defined in r8192U_core.c and only used locally are marked as static.
> > This fixes some warnings issued by sparse.
> > 
> > Signed-off-by: Antoine Schweitzer-Chaput <antoine at schweitzer-chaput.fr>
> 
> And it creates new warnings with gcc, which isn't acceptable :(

It does, but this warning's root cause was already present: these
functions are only called under specific compilation options but always
compiled.
This patch basically unhides this issue.

Since these are two different things I was reluctant to tackle both in
the same patch.

> Please fix these properly, I can't take patches that add warnings to the
> build.

I'll resend now, with an additional patch making sure these functions
are compiled only when they are used.

Antoine


More information about the devel mailing list