[patch] staging: lustre: bitwise vs logical typo

Dan Carpenter dan.carpenter at oracle.com
Thu Jul 31 15:21:34 UTC 2014


Bitwise AND was intended here obviously.

Signed-off-by: Dan Carpenter <dan.carpenter at oracle.com>
---
Static analysis.  I wasn't able to compile this.

Also lustre needs an entry in MAINTAINERS because otherwise
get_maintainer.pl still sends everything to Peng Tao only.

diff --git a/drivers/staging/lustre/lustre/obdecho/echo.c b/drivers/staging/lustre/lustre/obdecho/echo.c
index f3b7429..dae1599 100644
--- a/drivers/staging/lustre/lustre/obdecho/echo.c
+++ b/drivers/staging/lustre/lustre/obdecho/echo.c
@@ -125,7 +125,7 @@ static int echo_create(const struct lu_env *env, struct obd_export *exp,
 		return -EINVAL;
 	}
 
-	if (!(oa->o_mode && S_IFMT)) {
+	if (!(oa->o_mode & S_IFMT)) {
 		CERROR("echo obd: no type!\n");
 		return -ENOENT;
 	}


More information about the devel mailing list