[PATCH] staging: lustre: ldlm: ldlm_resource.c - fix dereferenceing user space buffer

Anil Belur askb23 at gmail.com
Thu Jul 31 06:07:05 UTC 2014


- this fixes sparse warning for directly deferencing user space buffer

./lustre/ldlm/ldlm_resource.c:202:35: warning: incorrect type in argument 2 (different address spaces)
./lustre/ldlm/ldlm_resource.c:202:35:    expected void const [noderef] <asn:1>*from
./lustre/ldlm/ldlm_resource.c:202:35:    got char const *buffer

Signed-off-by: Anil Belur <askb23 at gmail.com>
---
 drivers/staging/lustre/lustre/ldlm/ldlm_resource.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/drivers/staging/lustre/lustre/ldlm/ldlm_resource.c b/drivers/staging/lustre/lustre/ldlm/ldlm_resource.c
index 91d028b..efd45e5 100644
--- a/drivers/staging/lustre/lustre/ldlm/ldlm_resource.c
+++ b/drivers/staging/lustre/lustre/ldlm/ldlm_resource.c
@@ -189,8 +189,9 @@ static int lprocfs_lru_size_seq_show(struct seq_file *m, void *v)
 	return lprocfs_rd_uint(m, nr);
 }
 
-static ssize_t lprocfs_lru_size_seq_write(struct file *file, const char *buffer,
-				      size_t count, loff_t *off)
+static ssize_t lprocfs_lru_size_seq_write(struct file *file,
+					const char __user *buffer,
+					size_t count, loff_t *off)
 {
 	struct ldlm_namespace *ns = ((struct seq_file *)file->private_data)->private;
 	char dummy[MAX_STRING_SIZE + 1];
-- 
1.9.1



More information about the devel mailing list