[PATCH] staging: llite: rw.c: use gfp_t to store GFP flags

Greg KH gregkh at linuxfoundation.org
Tue Jul 22 02:08:05 UTC 2014


On Tue, Jul 22, 2014 at 02:57:57AM +0200, Guillaume Morin wrote:
> Use gfp_t to store GPF_* flags instead of unsigned int. 
> This was reported by sparse.
> 
> Signed-off-by: Guillaume Morin <guillaume at morinfr.org>
> ---
>  drivers/staging/lustre/lustre/llite/rw.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/staging/lustre/lustre/llite/rw.c b/drivers/staging/lustre/lustre/llite/rw.c
> index 5616210..3554272 100644
> --- a/drivers/staging/lustre/lustre/llite/rw.c
> +++ b/drivers/staging/lustre/lustre/llite/rw.c
> @@ -496,7 +496,7 @@ static int ll_read_ahead_page(const struct lu_env *env, struct cl_io *io,
>  	struct cl_object *clob  = ll_i2info(mapping->host)->lli_clob;
>  	struct cl_page   *page;
>  	enum ra_stat      which = _NR_RA_STAT; /* keep gcc happy */
> -	unsigned int      gfp_mask;
> +	gfp_t             gfp_mask;

Odd thing is, that function doesn't seem to even use that variable
anywhere...  Can you just remove it entirely?

thanks,

greg k-h


More information about the devel mailing list