[PATCH 00/29] staging: rtl8723au: Remove bad layer API

Greg KH gregkh at linuxfoundation.org
Mon Jul 21 19:10:58 UTC 2014


On Mon, Jul 21, 2014 at 11:24:40AM +0200, Jes.Sorensen at redhat.com wrote:
> From: Jes Sorensen <Jes.Sorensen at redhat.com>
> 
> Greg,
> 
> Another set of rtl8723au changes - this was meant to be a 'I'll just
> fix this little issue' but snowballed into a fair bit more, as I
> realized just how bad the original code was (patch 10 onwards).
> 
> The bulk of this set removes a bad layered API. The original driver is
> trying to moduralize different components (RF handling, baseband
> handling, 80211 handling etc). They try to create layer independant
> types they can pass around (which is bad enough by itself), but in
> this particular case they registered pointers to the original values
> and derefenced those, losing all type checking in the process and kept
> multiple defines of the same constants to use in each layer (patch 17). 
> 
> In addition there are a few other remove empty function fixes, and
> patch 29/29 fixes a locking issue that could be relevant for 3.16.
> 
> The set is clean against staging-next as of this morning.

All applied, thanks.

greg k-h


More information about the devel mailing list