[PATCH] staging: gdm72xx: conditionally compile debug code

Joe Perches joe at perches.com
Wed Jul 16 22:46:09 UTC 2014


On Wed, 2014-07-16 at 15:10 -0700, Greg KH wrote:
> On Wed, Jul 16, 2014 at 11:03:06PM +0100, Michalis Pappas wrote:
[]
> > Ok, I agree on the ifdef stuff. My question was regarding your
> > suggestion above to replace print_hex_debug() with dev_dbg()
> 
> You want the device name/id/label to show up as well, that is why you
> should use the dev_dbg() version, print_hex_dump() does not take a
> struct device *, so the user has no idea what device this data was
> coming from.

But Michalis could alway add something like:
	dev_hex_dump()
and
	dev_dbg_hex_dump()




More information about the devel mailing list