[PATCH 03/32] staging: comedi: comedidev.h: checkpatch.pl cleanup (else after return)

Greg KH gregkh at linuxfoundation.org
Wed Jul 16 22:03:20 UTC 2014


On Wed, Jul 16, 2014 at 09:27:02PM +0000, Hartley Sweeten wrote:
> On Wednesday, July 16, 2014 1:34 PM, Greg KH wrote:
> > On Wed, Jul 16, 2014 at 10:43:14AM -0700, H Hartley Sweeten wrote:
> >> Fix the checkpatch.pl warning in this file:
> >> 
> >> WARNING: else is not generally useful after a break or return
> >> 
> >> Also, for aesthetics, rename the comedi_subdevice parameter from
> >> 'subd' to 's' since this is the norm for comedi source files.
> >> 
> >> Signed-off-by: H Hartley Sweeten <hsweeten at visionengravers.com>
> >> Cc: Ian Abbott <abbotti at mev.co.uk>
> >> ---
> >>  drivers/staging/comedi/comedidev.h | 8 ++++----
> >>  1 file changed, 4 insertions(+), 4 deletions(-)
> >
> > Doesn't apply...
> 
> Not a problem.
> 
> You must have had some other patches that already
> fixed this and the first 2 in the series.

Yes, I think I got them from someone else the other day.

> I'll make sure to check linux-next to verify that the issues
> are resolved.

Thanks, that would be good.

greg k-h


More information about the devel mailing list