[PATCH 00/32] staging: comedi: checkpatch.pl cleanup (pass 1)

H Hartley Sweeten hsweeten at visionengravers.com
Wed Jul 16 17:43:11 UTC 2014


Start cleaning up the checkpatch.pl issues. This pass gets most of the:

WARNING: else is not generally useful after a break or return
WARNING: break is not useful after a goto or return

H Hartley Sweeten (32):
  staging: comedi: comedi_fops: checkpatch.pl cleanup (else after return)
  staging: comedi: comedi.h: checkpatch.pl cleanup (else after return)
  staging: comedi: comedidev.h: checkpatch.pl cleanup (else after return)
  staging: comedi: 8255_pci: checkpatch.pl cleanup (else after return)
  staging: comedi: 8255: checkpatch.pl cleanup (else after return)
  staging: comedi: addi_apci_3xxx: checkpatch.pl cleanup (else after return)
  staging: comedi: amplc_dio200_common: checkpatch.pl cleanup (else after return)
  staging: comedi: amplc_pc236: checkpatch.pl cleanup (else after return)
  staging: comedi: amplc_pci224: checkpatch.pl cleanup (else after return)
  staging: comedi: cb_pcidas64: checkpatch.pl cleanup (else after return)
  staging: comedi: daqboard2000: checkpatch.pl cleanup (else after return)
  staging: comedi: dt282x: checkpatch.pl cleanup (else after return)
  staging: comedi: pcl724: checkpatch.pl cleanup (else after return)
  staging: comedi: das1800: checkpatch.pl cleanup (break not useful)
  staging: comedi: ni_at_a2150: checkpatch.pl cleanup (break not useful)
  staging: comedi: s526: checkpatch.pl cleanup (break not useful)
  staging: comedi: cb_pcidas64: checkpatch.pl cleanup (break not useful)
  staging: comedi: cb_pcidas: checkpatch.pl cleanup (break not useful)
  staging: comedi: ni_660x: checkpatch.pl cleanup (break not useful)
  staging: comedi: ni_660x: checkpatch.pl cleanup (else not useful)
  staging: comedi: s626: checkpatch.pl cleanup (else not useful)
  staging: comedi: ni_mio_common: checkpatch.pl cleanup (break not useful)
  staging: comedi: ni_mio_common: checkpatch.pl cleanup (else not useful)
  staging: comedi: usbdux: checkpatch.pl cleanup (else not useful)
  staging: comedi: usbduxsigma: checkpatch.pl cleanup (else not useful)
  staging: comedi: ni_tio: checkpatch.pl cleanup (break is not useful)
  staging: comedi: ni_tio: checkpatch.pl cleanup (else is not useful)
  staging: comedi: ni_tiocmd: checkpatch.pl cleanup (break is not useful)
  staging: comedi: ni_labpc: checkpatch.pl cleanup (else is not useful)
  staging: comedi: das08: checkpatch.pl cleanup (break is not useful)
  staging: comedi: ni_tio_internal.c: checkpatch.pl cleanup (break is not useful)
  staging: comedi: mite.h: tidy up mite_csigr_wpdep()

 drivers/staging/comedi/comedi.h                    |   8 +-
 drivers/staging/comedi/comedi_fops.c               |   9 +-
 drivers/staging/comedi/comedidev.h                 |   8 +-
 drivers/staging/comedi/drivers/8255.c              |   3 +-
 drivers/staging/comedi/drivers/8255_pci.c          |   3 +-
 drivers/staging/comedi/drivers/addi_apci_3xxx.c    |  10 +-
 .../staging/comedi/drivers/amplc_dio200_common.c   |   8 +-
 drivers/staging/comedi/drivers/amplc_pc236.c       |   8 +-
 drivers/staging/comedi/drivers/amplc_pci224.c      |   3 +-
 drivers/staging/comedi/drivers/cb_pcidas.c         |   3 -
 drivers/staging/comedi/drivers/cb_pcidas64.c       |  29 ++----
 drivers/staging/comedi/drivers/daqboard2000.c      |   3 +-
 drivers/staging/comedi/drivers/das08.c             |   1 -
 drivers/staging/comedi/drivers/das1800.c           |   8 --
 drivers/staging/comedi/drivers/dt282x.c            |   8 +-
 drivers/staging/comedi/drivers/mite.h              |   8 +-
 drivers/staging/comedi/drivers/ni_660x.c           |   7 +-
 drivers/staging/comedi/drivers/ni_at_a2150.c       |   1 -
 drivers/staging/comedi/drivers/ni_labpc.c          |   4 +-
 drivers/staging/comedi/drivers/ni_mio_common.c     | 101 ++++++--------------
 drivers/staging/comedi/drivers/ni_tio.c            | 105 ++++-----------------
 drivers/staging/comedi/drivers/ni_tio_internal.h   |   2 -
 drivers/staging/comedi/drivers/ni_tiocmd.c         |   1 -
 drivers/staging/comedi/drivers/pcl724.c            |   6 +-
 drivers/staging/comedi/drivers/s526.c              |   1 -
 drivers/staging/comedi/drivers/s626.c              |  12 +--
 drivers/staging/comedi/drivers/usbdux.c            |  12 +--
 drivers/staging/comedi/drivers/usbduxsigma.c       |  12 +--
 28 files changed, 108 insertions(+), 276 deletions(-)

-- 
1.9.3



More information about the devel mailing list