[PATCH 01/15] staging: comedi: ni_daq_700: remove unnecessary enable and flush of ADC

Hartley Sweeten HartleyS at visionengravers.com
Wed Jul 16 17:25:30 UTC 2014


On Wednesday, July 16, 2014 4:35 AM, Ian Abbott wrote:
> On 2014-07-15 01:20, H Hartley Sweeten wrote:
>> The ADC conversions are enabled and the FIFO is flushed by daq700_ai_config()
>> when the driver is initially attached. There is no reason to repeat the ADC
>> enable and flush the FIFO before each sample read in the (*insn_read).
>>
>> Signed-off-by: H Hartley Sweeten <hsweeten at visionengravers.com>
>> Cc: Ian Abbott <abbotti at mev.co.uk>
>> Cc: Greg Kroah-Hartman <gregk at linuxfoundation.org>
>
> I wouldn't be comfortable changing that - it looks important.  Could you 
> run it past Fred Brooks?

Greg,

Please drop this series until I can get some feedback from Fred Brooks.

Thanks,
Hartley



More information about the devel mailing list