[PATCH] staging: r8821ae: avoid leaking format string

Greg Kroah-Hartman gregkh at linuxfoundation.org
Thu Jul 10 20:38:25 UTC 2014


On Thu, Jul 10, 2014 at 01:16:11PM -0700, Kees Cook wrote:
> This make sure a format string cannot leak into the work queue name nor
> the printk buffer.
> 
> Signed-off-by: Kees Cook <keescook at chromium.org>
> ---
> This is the third time this set of macros has entered the kernel:
> 
> drivers/net/wireless/rtlwifi/btcoexist/halbtcoutsrc.h
> drivers/staging/rtl8192ee/btcoexist/halbtcoutsrc.h
> drivers/staging/rtl8821ae/btcoexist/halbtcoutsrc.h
> 
> Can we extract these macros to some common place and keep them from returning?

I wish.  These are all from the same company.  Each new version of their
hardware consists of a whole dump of a wireless stack.  People are
working on addressing this issue, by writing "real" drivers for the
hardware, and working with the company to not keep doing this.  But odds
are, I'll get a new driver for the next chip from them that does the
same thing :(

thanks for the patch, I'll queue it up.

greg k-h


More information about the devel mailing list